Re: [GIT PULL] hardening fixes for v6.16-rc1 - Linus Torvalds
lore.kernel.org
  • ashaman2007@lemm.ee
    81·
    2 days ago

    Short TL;DR: nothing burger

    Longer TL;DR: Linus sees bad changes to the git tree by Kees Cook that he interprets as being of human origin and intentional, calls them “malicious” changes and orders that Kees Cook’s privileges be revoked. Turns out that the “git-filter-repo” tool being used was actually the culprit as it is very powerful and incorrect usage explains the changes. Discussion then moves toward implementing safety checks in the tooling. Kees gets his permissions back.

    • vaguerant@fedia.io
      38·
      2 days ago

      Cook’s razor: “Never attribute to malice that which is adequately explained by screwing up git commands.”

      • koper@feddit.nl
        29·
        2 days ago

        The person who created git clearly cannot be trusted to write good kernel code. I’m CC’ing Konstantin to disable his account, whoever he is.

      • 6nk06@sh.itjust.works
        813·
        2 days ago

        screwing up git commands

        You mean “using git.” It’s the only piece of software that I hate with Oracle. Jujutsu is a breath of fresh air and I can ignore that git ever existed.

        • Dark Arc@social.packetloss.ggEnglish
          171·
          2 days ago

          git is genuinely one of the best tools ever created. It is an extremely simple idea with crazy effectiveness and a reasonable UX that is a bit off putting at first but makes a lot of sense later on.

          That said, I’d genuinely be curious what you think jj has improved upon git.

          • 6nk06@sh.itjust.works
            41·
            1 day ago

            The command line of jj makes sense and is easy to understand. I have to use graphical git clients because I want to cry every time I have to use its CLI.

            • Dark Arc@social.packetloss.ggEnglish
              3·
              13 hours ago

              That’s interesting; I find the git CLI pretty intuitive especially for basic use cases most people would need, but I’ve also used git for 15 years now.

              • FizzyOrange@programming.dev
                1·
                7 hours ago

                I find the git CLI pretty intuitive

                You might be the first person to ever say that! How do I delete a remote branch?

              • ulterno@programming.devEnglish
                1·
                11 hours ago

                I have only been using it for ~ 4 years and the UX seems pretty logical even for not-basic cases.

                Maybe because it was only my second VCS[1], it didn’t seem at all problematic to me. On the contrary, every time, I just found myself going “nice”, whenever I found a new feature.

                When it comes to git restore ., well, you won’t use rm -rf * in your working directory, right?

                I haven’t used git based GUIs much. Some of the functions that my IDE provides, I use now and then. Being able to see the git blame for a file, right in place, scrolled to the same line as I was looking at the code, helps quite a bit (and so does the git based annotations).
                But for things like commit, restore, pull, push, rebase and things that will write something, I just use the CLI, because I feel like I know what is going to happen ad that gives me confidence.

                1. the first one being folders with timestamps ↩︎

  • mvirts@lemmy.world
    9·
    2 days ago

    Sometimes a short bit of drama is good motivation to actually read the mailing list 😁